[Pg]: Forward all $with arguments through withReplicas - #6161
Open
godoom wants to merge 1 commit into
Open
Conversation
Postgres $with accepts an optional selection argument. withReplicas only forwarded the first argument, so CTE selection maps were dropped when queries went through a replica.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withReplicasforwarded only the first argument of$with, sodb.$with(alias, selection)dropped the CTE selection map on replica queries.$withnow spreads all arguments, matchingwith,select, and the other replica wrappers.aliasandselectionare forwarded to the chosen replica or$primary.Test plan
$withon primary, a random replica, a single replica, mixed replica + primary, and a fixed first replicacd integration-tests && pnpm exec vitest run tests/replicas/postgres.test.tsdb.$with('sq', { ... }).as(sql\...`)works throughwithReplicas`