fix(expo-sqlite): make journal optional in useMigrations migration config - #5428
fix(expo-sqlite): make journal optional in useMigrations migration config#5428sleitor wants to merge 1 commit into
Conversation
|
👋 Gentle ping — just checking if this is still on the radar for review. Happy to address any feedback or rebase if needed! |
|
Hi @sleitor I think you can remove |
|
Thanks for the pointer @rvieceli! Making If the drizzle team prefers to remove it outright (treating V0/V1 format as unsupported in |
In V2 migrations, the generated object no longer includes a `journal` field. However, useMigrations() required it in its type signature even though it was never used (passed as `migrations as any` to migrate()). Making `journal` optional fixes the TypeScript error for users on V2 migrations without breaking existing code. Fixes drizzle-team#5214
Fixes #5214
Problem
useMigrations()requires ajournalproperty in the second argument, but thejournalfield is never read — the function just passes the object asmigrations as anytomigrate(). Users generating migrations with the new V1 format don't have ajournalfile and hit a TypeScript compile error:Fix
Mark
journalas optional (journal?) in theuseMigrationsparameter type. No runtime behaviour changes — the field was already unused.