Dispatch Serializable subclasses of registered types to themselves#56
Open
renan-r-santos wants to merge 1 commit into
Open
Dispatch Serializable subclasses of registered types to themselves#56renan-r-santos wants to merge 1 commit into
Serializable subclasses of registered types to themselves#56renan-r-santos wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Serializablesubclass that also inherits a type with a registered serializer, for example,class UUID7(UUID, Serializable),class Tag(str, Serializable), used to silently dispatch to the base's serializer (the MRO walk foundUuidSerializer/StringSerializerfirst), so its ownfrom_data/to_datawere ignored. This makes such a class win as its own serializer, which is what enables defining custom scalar types.An explicit
serializer.register(...)still takes precedence over this rule, and the same handling applies to generic origins (Box[int],TypedList[int]). Since a custom scalar typically isn't an OpenAPI component, its schema is inlined into the owning model rather than emitted as a separate$ref.