Define Result as a union of Success and Failure to express a closed sum type#54
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 34 34
Lines 1524 1524
Branches 232 232
=======================================
Hits 1409 1409
Misses 50 50
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
I guess until we get the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serialite.Resultaliases thereturnsabstract base classResult. A type checker cannot prove amatchon it is exhaustive, even when bothSuccessandFailureare handled.MRE:
Both arms return or raise (
raise_errorsisNoReturn), so this is exhaustive.pyreflyrejects it:A wildcard
case _ as other: assert_never(other)shows the subject is never narrowed past the two arms:Root cause:
returns.result.Resultis an abstract base class. Nominal subclassing is open, so a checker must assume a third subclass could exist. MakingResulta union of exactlySuccessandFailurefixes this. Each case eliminates one arm, and the match narrows toNever. A union is needed because Python has no sealed to close the base class.