Allow envelope sender override per message#48
Open
samumbach wants to merge 1 commit intodrewr:masterfrom
Open
Conversation
|
I don't have commit rights, but this makes sense to me. |
b199c5a to
382cb0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress
This is just a failing test demonstrating the behavior I'd like to see. There is currently some inconsistency between sendmail and smtp transports:
Ideally, the :sender key could be used to set the SMTP envelope sender for both the smtp and sendmail transports. To make this happen, we will need to create a new Session instance for each message with a :sender key.
What do you think?