[ios_zip_validation] Validate zip#56
Conversation
tschuls
left a comment
tschuls
left a comment
There was a problem hiding this comment.
I do not agree to solve this logic in the iOS only part, since we have the same problem in Android as well. I will propose another solution.
…dation # Conflicts: # iOS/Multiplatform Redux Sample/Multiplatform Redux Sample/Resources/en.lproj/Localizable.strings
|
Code Climate has analyzed commit ce3aede and detected 0 issues on this pull request. View more on Code Climate. |
tschuls
left a comment
tschuls
left a comment
There was a problem hiding this comment.
@Nils-Becker my understanding of the problem is:
- limiting the number of digits to 4
- not allowing back navigation if there is no valid zip
-> I did Add the limitation of 4 digits to android as well, the second point I handled in the State and reused it on both platforms. Is it okay with you?
|
I think there should be a way to cancel changing the zip code in the settings. Maybe we could have a "save" button in the upper right corner that is only enabled if the entry is valid and navigating back always discards your changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
https://app.asana.com/0/1199509904376633/1199959636277655/f