Skip to content

chore(fix): release github action#56

Merged
drehelis merged 4 commits intomainfrom
reusable_release_gha
Apr 4, 2026
Merged

chore(fix): release github action#56
drehelis merged 4 commits intomainfrom
reusable_release_gha

Conversation

@drehelis
Copy link
Copy Markdown
Owner

@drehelis drehelis commented Apr 4, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 4, 2026 12:15
@drehelis drehelis changed the title Reusable release gha chore(fix): release github action Apr 4, 2026
@drehelis drehelis merged commit fcb1e91 into main Apr 4, 2026
6 checks passed
@drehelis drehelis deleted the reusable_release_gha branch April 4, 2026 12:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s release automation to better support a reusable release GitHub Actions workflow, and makes a small theme variable adjustment in the CSS.

Changes:

  • Add workflow-level concurrency control to serialize release runs.
  • Expand GITHUB_TOKEN permissions for the release workflow to enable write operations.
  • Simplify a theme CSS variable definition for --bmc-color.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/index.css Tweaks theme variable definition for --bmc-color.
.github/workflows/release.yml Adds concurrency settings and explicit token permissions for the reusable release workflow invocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

--theme-text-muted: #657b83;
--theme-text-bright: #073642;
--bmc-color: #cb4b16; /* Same as theme-orange for high contrast on light bg */
--bmc-color: #cb4b16;
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--bmc-color duplicates the value of --theme-orange in this theme. To avoid drift if --theme-orange is updated later, set --bmc-color to reference the theme variable (e.g., via var(--theme-orange)) instead of repeating the hex value.

Suggested change
--bmc-color: #cb4b16;
--bmc-color: var(--theme-orange);

Copilot uses AI. Check for mistakes.
Comment on lines +29 to +31
permissions:
contents: write
pull-requests: write
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow grants contents: write and pull-requests: write to a reusable workflow sourced from another repository (and referenced via a floating @main ref). With secrets: inherit, this materially increases supply-chain blast radius if the upstream workflow changes. Consider pinning the reusable workflow to an immutable ref (tag/SHA) and scoping token permissions (and passed secrets) to the minimum actually required for the release job.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants