Right-size Azure DC02 memory - #431
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Makes Azure GOAD VM sizing declarative, allocating additional memory to DC02.
Changes:
- Adds per-host Azure VM size defaults with a safe fallback.
- Updates environment generation and regression coverage.
- Documents overrides and migration guidance.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
infra/azure/goad-deployment/test/env.hcl |
Defines per-host size defaults. |
infra/azure/goad-deployment/test/centralus/goad/dc01/terragrunt.hcl |
Resolves DC01 size from environment settings. |
infra/azure/goad-deployment/test/centralus/goad/dc02/terragrunt.hcl |
Resolves DC02’s larger size. |
infra/azure/goad-deployment/test/centralus/goad/dc03/terragrunt.hcl |
Resolves DC03 size from environment settings. |
infra/azure/goad-deployment/test/centralus/goad/srv02/terragrunt.hcl |
Resolves SRV02 size from environment settings. |
infra/azure/goad-deployment/test/centralus/goad/srv03/terragrunt.hcl |
Resolves SRV03 size from environment settings. |
docs/mkdocs/docs/providers/azure.md |
Documents sizing and migration. |
cli/cmd/env_cmd.go |
Generates Azure sizing defaults. |
cli/cmd/env_cmd_test.go |
Tests generated sizing values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DC02 carries the recurring attack-simulation workload and needs more memory than the other Azure lab hosts. This makes that sizing declarative so subsequent Terragrunt applies preserve it.
Added
goad_instance_sizesdefaults in generated Azure environments, with DC02 onStandard_D4s_v3and the remaining GOAD hosts onStandard_D2s_v3.Changed
Standard_D2s_v3fallback for missing or partial configuration.Notes
instance_size = "Standard_D4s_v3"in their existingdc02/terragrunt.hclbefore the next apply.