fix: resolve lab config through active environment for scoring - #405
Merged
Merged
Conversation
**Changed:** - Score key generation now resolves the GOAD config via the active environment's `ResolvedLabConfigPath()` instead of hardcoding `ad/GOAD/data/config.json`, so overlays and variant labs are honored for the selected `--env` - `cli/cmd/score.go` - Scoreboard demo and generate-key alias commands use the same environment-resolved config path, ensuring the correct lab is scored - `cli/cmd/scoreboard.go` - Updated flag help text for `--config` to describe the new default as the active environment's resolved lab config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
ad/GOAD/data/config.jsonpath withcfg.ResolvedLabConfigPath()so overlays and variant labs are scored correctlyChanged:
runScoreGenerateKey- Replaced the hardcodedad/GOAD/data/config.jsonfallback withcfg.ResolvedLabConfigPath(), ensuring the selected--env, overlays, and variant labs are honored instead of always scoring the base lab (cli/cmd/score.go)runScoreboardDemo- Applied the same environment-aware resolution so demo scoring matches the active environment (cli/cmd/scoreboard.go)--configflag descriptions across the score generate-key, scoreboard generate-key alias, and scoreboard demo commands to describe the new default as "the active environment's resolved lab config" (cli/cmd/score.go,cli/cmd/scoreboard.go)