Skip to content

Update 10_wait_for_requests.md#199

Open
lorentzlasson wants to merge 1 commit intodrashland:mainfrom
lorentzlasson:patch-1
Open

Update 10_wait_for_requests.md#199
lorentzlasson wants to merge 1 commit intodrashland:mainfrom
lorentzlasson:patch-1

Conversation

@lorentzlasson
Copy link
Copy Markdown

Summary

  • Fix selector in test (#button does not exist)
  • Fix dummy server response (rendered as text unless html type is specified)
  • Use non-deprecated http serve
  • Include sinco import directly in file

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drash-land ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 4:37pm

Copy link
Copy Markdown
Contributor

@ebebbington ebebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment but looks good thank you :)

import { buildFor } from "./deps.ts";

import { buildFor } from "https://deno.land/x/sinco@v4.1.0/mod.ts";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally would still pont to deps.ts so we can reference the sinco version once at the start of the tutorial to help with auto bumping the version

@lorentzlasson
Copy link
Copy Markdown
Author

@ebebbington ✔️

@lorentzlasson
Copy link
Copy Markdown
Author

@ebebbington relevant still or should I close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants