myClock V1.0 RELEASE

[dragondaud]

Intending to push V1.0, Soon, after any bugs are fixed, and the following features implemented.

• Support for Celsius temperature display (both local/indoor and openweather)

• Support for localization of weather descriptions

• Rework each config option into its own control on webpage

• Update directly from github binary release, manually or automatically

• Verify/fix functionality of GeoIP automatic location, outside USA

• Add country code to ?zip= weather lookup, outside USA

• Support ESP32 module

• Better Documentation :)

[hallard]

Very nice.

I also tested something for information. It's about openweather and got weather condition related to my country language (last line of display) but for this you need 2 things:

• set language on api call (so need to be an option on json file) lang=FR
String URL = PSTR("http://api.openweathermap.org/data/2.5/weather?zip=") + location + F("&units=metric&lang=FR&appid=") + owKey;
• use field description instead of main
String description = weather["description"];
  now it displays nuageux instead of cloudy

About Celsius conversion, I think colors should be adjusted to "classic" °C threeshold values such as

        if (temperature < 0) display.setTextColor(myCYAN);
        else if (temperature < 10) display.setTextColor(myBLUE);
        else if (temperature < 15) display.setTextColor(myMAGENTA);
        else if (temperature < 25) display.setTextColor(myGREEN);
        else if (temperature >= 25) display.setTextColor(myYELLOW);
        else if (temperature >= 30) display.setTextColor(myORANGE);
        else if (temperature >= 35) display.setTextColor(myRED);

I let you change the colors of course, what's important are the digit such as 0 10 15 25 30 and 35 and I think we could even add 20°C threshold because it's the confort temperature on a house

[dragondaud]

I pushed a new version, with language support and made some changes to the top line color selection. Eventually there will be a drop down for language, but for now it's just another field in the config.json file. Thanks for the feedback!

[dragondaud]

I ad originally used the "short" description because some of the english texts are very long, but enabling localization seems like a good idea, and its only available on the long description. After looking through them again, it seems to be mostly excessive use of "intensity" that causes the long ones. So, I'm removing the word from output. Today at my locale we were having 'light intensity drizzle'. which becomes simply 'light drizzle' and it seems the FR version doesn't have extra unnecessary words.

[anthonyjclarke]

Hey, just found this 👍 One thing I was about to (newbie!) try and do was embed DST - currently, my running version is an hour out as we are on daylight savings. I've used this library before... https://github.com/neptune2/simpleDSTadjust, is this something to add? :)

[dragondaud]

myClock automatically adjusts for DST, if you location is correct. By default it will use geoIP to determine your timezone, and location for weather info. If that is wrong, then you can manually set your location on the webpage of the clock.

[anthonyjclarke]

Perfect, thanks... if only I could get it to compile :( See the issue I opened! Appreciate your help

[anthonyjclarke]

Working now,

Dont know if it was just me, but to get code to work in Tools, I had to set Flash as :

Once operating, with String Location as empty then If I left as "/forecast?q=" then got an Json parse error

Some issues with the openweather API Call.

By default, with String location; // Blank

This is the serial output

getIPlocation: Telstra Internet, New South Wales, AU, Australia/Sydney
17:58:11.879 -> setup: Ryde, AU, Australia/Sydney, true, 255, 0
setNTP: configure NTP .... OK
17:58:15.684 -> setNTP: next timezone check @ Tue Oct 16 02:00:00 2018
17:58
http://api.openweathermap.org/data/2.5/weather?zip=Ryde, AU&units=metric&lang=en&appid=xxx
getWeather: GET failed: 404
17:58 0 255

If I change the api string to /weather?q= then I get this

getIPlocation: Telstra Internet, New South Wales, AU, Australia/Sydney
18:00:34.967 -> setup: 2112, Australia/Sydney, true, 255, 0
setNTP: configure NTP ..... OK
18:00:37.767 -> setNTP: next timezone check @ Tue Oct 16 02:00:00 2018
18:00
http://api.openweathermap.org/data/2.5/weather?q=2112&units=metric&lang=en&appid=xxx
9F, 61%, 2 E (130), clear sky (800)

The wrong weather, clearly my ZIP (Postcode) of 2112 does not work.

Checking here - https://openweathermap.org/current if I force my location to : String location = "Ryde, AU";

Then it works :-

18:11:06.472 -> readSPIFFS: mounted
getIPlocation: Telstra Internet, New South Wales, AU, Australia/Sydney
18:11:12.670 -> setup: Ryde, AU, Australia/Sydney, true, 255, 0
18:11:12.670 -> setNTP: configure NTP ..... OK
18:11:14.671 -> setNTP: next timezone check @ Tue Oct 16 02:00:00 2018
18:11
http://api.openweathermap.org/data/2.5/weather?q=Ryde, AU&units=metric&lang=en&appid=xxx
21F, 68%, 8 NE (50), shower rain (521)
18:11 0 255

So there is some inconsistency here in the GetIPlocation, seems to return Ryde, AU sometimes and 2112 other times.

[dragondaud]

A space is not valid in a URL, unless encoded as %20, so to use the ?q=City,CC lookup format, make sure there is no space after the comma. As for postal code, I just noticed in the API doc that the default is USA and to use another country's postal code you must specify it like:
api.openweathermap.org/data/2.5/weather?zip={zip code},{country code}
So I will look at making an update to support that.

[anthonyjclarke]

Enhancement request :)
Would love to see Day, Date displayed. With limited real estate perhaps the weather could alternate with the date?

[dragondaud]

The local Country Code, as obtained from ip-api.com, is now included with weather lookup request.
Personally, I wouldn't want my clock's display so busy with alternating the date. Right now I'm working towards a 1.0 release, with emphasis on usability and stability. After that, new features might be added. Thanks for your input.

[anthonyjclarke]

Dave - just wondering if this is a "bug" / "undocumented feature" :) the pixels on the bottom line? Seem random?

[dragondaud]

The code that clears the bottom was fixed a few commits back. Previously, with short descriptions, the very bottom line was never used and I didn't notice the error, but it should be fixed in the current code. The red number that appears occasionally is the status code returned if the weather lookup fails.