Repository navigation
Wait until the test corpus is loaded before testing - #402
Merged
Merged
Conversation
cmil
added this pull request to stack #393
October 18, 2026 13:56
cmil
marked this pull request as ready for review
October 18, 2026 13:56
Merging this PR will leave 2 of 36 operations untested. Please review.
❌ Untested (2)
🟡 Tested (34)
24 more
Powered by TraceCov v0.25.3 schemathesis 4.31.1 | http://localhost:8081/exist/restxq/v1/openapi.yaml |
cmil
force-pushed
the
wait-for-test-corpus
branch
from
October 18, 2026 14:22
2a723a1 to
3b1eb10
Compare
The loadtest container waited for `"plays":[{`, which never matches the
indented JSON of the API, so it always gave up after 60 s while the
corpus was still loading, and nothing checked its exit code: `docker
compose up --wait` doesn't wait for it to finish. The tests therefore
always started while the corpus was loading, which went unnoticed as
long as loading finished early in the first test run. When loading
didn't finish at all, as in a run on the Ubuntu 26.04 runner, this only
showed minutes later as an error in the DTS validator.
The container now waits up to 5 minutes for the commit of the corpus,
which the load job records after loading all plays, and the workflow
fails right after starting the stack, with the logs of loadtest and
api, if loading doesn't succeed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cmil
force-pushed
the
wait-for-test-corpus
branch
from
October 18, 2026 14:24
3b1eb10 to
393e09c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the run that prompted this, loading didn't finish at all, and the tests started with an empty corpus anyway. Why loading failed there can't be told, as the container logs weren't collected; with this change they would be: https://github.com/dracor-org/dracor-api/actions/runs/39131574060/attempts/1
🤖 Generated with Claude Code