Skip to content

Bugfixes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fireb0rngg wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfixes #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4edfb9c
Fix in-game changes to invincibility conditions not changing enabled …
fireb0rngg Apr 15, 2026
32b58a6
Fix improperly granting Needolin invincibility
fireb0rngg Apr 15, 2026
1912441
Fixed Needolin invincibility condition activating on ActiveOuter
fireb0rngg Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Conditions/InvincibilityCondition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ private set
if (field == value)
return;
DoUpdate(() => field = value);
IsEnabled = plugin.PluginEnabled && value;
}
}

Expand Down
8 changes: 3 additions & 5 deletions Conditions/NeedolinCondition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System.Collections.Generic;
using System.Linq;
using HutongGames.PlayMaker;
using HutongGames.PlayMaker.Actions;
using MonoDetour;
using MonoDetour.HookGen;
Expand All @@ -25,11 +24,10 @@ internal NeedolinCondition(InvincibilityMonitorPlugin plugin)
private readonly HashSet<CheckHeroPerformanceRegion> checks = [];
private readonly HashSet<CheckHeroPerformanceRegionV2> checksV2 = [];

private static bool IsNone(FsmEvent? fsmEvent) => fsmEvent == null || fsmEvent.name == "";

protected override bool Callback() =>
checks.Any(c => !IsNone(c.None) && c.active)
|| checksV2.Any(c => !IsNone(c.None) && c.active);
HeroPerformanceRegion.IsPerforming
&& (checks.Any(c => c.affectedState == HeroPerformanceRegion.AffectedState.ActiveInner)
|| checksV2.Any(c => c.affectedState == HeroPerformanceRegion.AffectedState.ActiveInner));

private static void PostfixOnEnter(CheckHeroPerformanceRegion self)
{
Expand Down