feat: support loading multiple markdown sources via sourceUrls option#20
Merged
Conversation
Adds a sourceUrls option (array of URLs) to createSlideshow(). All URLs are fetched in parallel, then their content is concatenated in order (joined with \n---\n slide separators) and parsed as a single deck. Also exposes loadFromUrls() as a public method on Slideshow, mirroring the existing loadFromUrl() and loadFromString() API. When both sourceUrls and sourceUrl are provided, sourceUrls takes precedence. Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourceUrls: string[]toSlideshowOptions\n---\nslide separators), then parses as a single deckloadFromUrls(urls, callback)as a public method alongside the existingloadFromUrl/loadFromStringsourceUrlsandsourceUrlare provided,sourceUrlstakes precedenceAPI
Implementation notes
XMLHttpRequestabstraction (same asloadFromUrl), wrapped in aPromisePromise.allfetches all concurrently; order is preserved by the array join\n---\nso each file's content starts as a new slide, even if the file itself doesn't end with a separatorCloses #7