Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/__tests__/lexer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,14 @@ describe('Lexer', () => {
it('recognizes ??? notes separator', () => {
expect(lexer.lex('\n???\n')).toEqual([{ type: 'notes_separator', text: '???' }]);
});

it('recognizes ??? with trailing spaces (issue #1)', () => {
expect(lexer.lex('\n??? \n')).toEqual([{ type: 'notes_separator', text: '???' }]);
});

it('recognizes ??? with trailing tabs (issue #1)', () => {
expect(lexer.lex('\n???\t\n')).toEqual([{ type: 'notes_separator', text: '???' }]);
});
});

describe('code blocks', () => {
Expand Down
12 changes: 12 additions & 0 deletions src/__tests__/parser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,18 @@ describe('Parser', () => {
it('removes notes from slide content', () => {
expect(parser.parse('content\n???\nnotes')[0].content).toEqual(['content']);
});

it('parses notes after ??? with trailing spaces (issue #1)', () => {
const slide = parser.parse('content\n??? \nnotes')[0];
expect(slide.notes).toEqual(['notes']);
expect(slide.content).toEqual(['content']);
});

it('parses notes after ??? with trailing tab (issue #1)', () => {
const slide = parser.parse('content\n???\t\nnotes')[0];
expect(slide.notes).toEqual(['notes']);
expect(slide.content).toEqual(['content']);
});
});

describe('fenced code blocks', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/mdeck/lexer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const regexByName: Record<string, RegExp> = {
MACRO: /!\[:([^\] ]+)([^\]]*)\](?:\(([^\)]*)\))?/,
SLIDE_SEPARATOR: /(?:^|\n)(---|<!--\s*break\s*-->)(?:\n|$)/,
FRAGMENT_SEPARATOR: /(?:^|\n)(--)(?![^\n])/,
NOTES_SEPARATOR: /(?:^|\n)(\?{3})(?:\n|$)/,
NOTES_SEPARATOR: /(?:^|\n)(\?{3})[ \t]*(?:\n|$)/,
};

function replace(regex: RegExp, replacements: Record<string, RegExp>): RegExp {
Expand Down