fix: only extract properties from leading front-matter block#15
Merged
Conversation
Previously extractProperties used a greedy regex that consumed any 'word: value' line anywhere in the slide source, causing content lines like 'Example: this line disappears' to be silently eaten as properties. Now property extraction stops at the first blank line or non-property line, matching YAML front-matter conventions. HTML comment properties (<!-- key: value -->) are still extracted anywhere as they are invisible markers by design. Closes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractPropertiesinparser.tsto stop consumingkey: valuelines once a blank line or non-property line is encountered<!-- key: value -->) are still extracted anywhere in the source since they are invisible markers by designRoot cause
The old implementation used a single greedy regex with no anchor:
This matched any
word: valueline anywhere in the slide source, silently consuming content likeExample: this line disappearsas a property.Fix
Property extraction now works like YAML front-matter:
key: valuelinesLines appearing after content are never treated as properties.
Closes #4