Skip to content

test: verify jump-to-slide shortcut works correctly with countIncrementalSlides=false#14

Merged
dpecos merged 1 commit into
masterfrom
fix/issue-10-jump-to-slide-incremental
Apr 16, 2026
Merged

test: verify jump-to-slide shortcut works correctly with countIncrementalSlides=false#14
dpecos merged 1 commit into
masterfrom
fix/issue-10-jump-to-slide-incremental

Conversation

@dpecos
Copy link
Copy Markdown
Contributor

@dpecos dpecos commented Apr 16, 2026

Summary

Investigation

After tracing through createSlides() in slideshow.ts, the bug from issue #10 could not be reproduced. The byNumber mapping correctly:

  • Assigns slide numbers [1, 2, 2, 3] when an incremental (--) slide is present and countIncrementalSlides: false
  • Groups Slide 2 and its incremental Slide 2b under byNumber[2]
  • Maps byNumber[3] exclusively to Slide 3 (the last slide)
  • Ensures typing 3 + Enter navigates to Slide 3 as expected

Tests added

Six new assertions under number mapping > jump-to-slide with countIncrementalSlides: false (issue #10) covering the exact scenario from the issue report.

Closes #10

…s=false

Adds regression tests covering the scenario from issue #10 to confirm
that byNumber mapping correctly groups incremental slides and that typing
a slide number navigates to the expected displayed slide.

Closes #10
@dpecos dpecos merged commit 85e3de6 into master Apr 16, 2026
4 checks passed
@dpecos dpecos deleted the fix/issue-10-jump-to-slide-incremental branch April 16, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: jump-to-slide shortcut uses wrong numbers when countIncrementalSlides is false

1 participant