test: verify jump-to-slide shortcut works correctly with countIncrementalSlides=false#14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
byNumbermapping already handlescountIncrementalSlides: falsecorrectlyInvestigation
After tracing through
createSlides()inslideshow.ts, the bug from issue #10 could not be reproduced. ThebyNumbermapping correctly:[1, 2, 2, 3]when an incremental (--) slide is present andcountIncrementalSlides: falsebyNumber[2]byNumber[3]exclusively to Slide 3 (the last slide)3+ Enter navigates to Slide 3 as expectedTests added
Six new assertions under
number mapping > jump-to-slide with countIncrementalSlides: false (issue #10)covering the exact scenario from the issue report.Closes #10