This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Add error handling and retry mechanism to curl calls within curlgh#14
Closed
aleveille wants to merge 1 commit intodpb587:developfrom
aleveille:develop
Closed
Add error handling and retry mechanism to curl calls within curlgh#14aleveille wants to merge 1 commit intodpb587:developfrom aleveille:develop
aleveille wants to merge 1 commit intodpb587:developfrom
aleveille:develop
Conversation
Open
Author
|
If #15 is merged first, I can rebase my PR on it to use the same retry_count and retry_timeout flags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC :)
We've seen a few pipelines fails because of rate-limit / network issue / don't trust the Internet.
For instance, we've had instances of pipelines fail because of rate-limiting it logged in the Concourse job's step logs: "Not found for ". Our developers were quite confused by this and we wanted to better handle some HTTP errors to give relevant feedback in the resource's logs.
Therefore, I've added some error handling and retry mechanism for curlgh. The main idea is to dump the HTTP response headers in /tmp/responseheaders and check whether we had a 200 OK back (or not - and then handle it).
Points of discussions: