Skip to content

Fix event handling in a Shadow DOM #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbaechler wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix event handling in a Shadow DOM #1647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0b9261
add shadow dom test
sbaechler May 12, 2025
a06a26b
Patch DOM traversal
sbaechler May 13, 2025
f7e0452
Increase test coverage
sbaechler May 13, 2025
886b569
Add test for search
sbaechler May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions cypress/e2e/useMultipleCombobox.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,73 @@ describe('useMultipleCombobox', () => {
it('can select multiple items', () => {
cy.findByRole('button', {name: 'toggle menu'}).click()
cy.findByRole('option', {name: 'Green'}).click()
cy.findByRole('button', {name: 'toggle menu'}).should(
'have.attr',
'aria-expanded',
'true',
)
cy.findByRole('option', {name: 'Gray'}).click()
cy.findByRole('button', {name: 'toggle menu'}).click()
cy.findByRole('button', {name: 'toggle menu'}).should(
'have.attr',
'aria-expanded',
'false',
)
cy.findByText('Black').should('be.visible')
cy.findByText('Red').should('be.visible')
cy.findByText('Green').should('be.visible')
cy.findByText('Gray').should('be.visible')
})
})

describe('useMultipleCombobox in shadow DOM', () => {
beforeEach(() => {
cy.visit('/shadow-dom/useMultipleCombobox')
})

it('can select multiple items within a shadow DOM', () => {
cy.get('[data-testid="shadow-root"]')
.shadow()
.within(() => {
cy.findByRole('button', {name: 'toggle menu'}).click()
cy.findByRole('option', {name: 'Green'}).click()
cy.findByRole('button', {name: 'toggle menu'}).should(
'have.attr',
'aria-expanded',
'true',
)
cy.findByRole('option', {name: 'Gray'}).click()
cy.findByRole('button', {name: 'toggle menu'}).click()
cy.findByRole('button', {name: 'toggle menu'}).should(
'have.attr',
'aria-expanded',
'false',
)
cy.findByText('Black').should('be.visible')
cy.findByText('Red').should('be.visible')
cy.findByText('Green').should('be.visible')
cy.findByText('Gray').should('be.visible')
})
})

it('can filter the items', () => {
cy.get('[data-testid="shadow-root"]')
.shadow()
.within(() => {
cy.findByRole('button', {name: 'toggle menu'}).click()
cy.findAllByRole('option').should('have.length', 12)
cy.findByRole('combobox').type('g')
cy.findByRole('button', {name: 'toggle menu'}).should(
'have.attr',
'aria-expanded',
'true',
)
cy.findAllByRole('option').should('have.length', 2)
cy.findByText('Green').should('be.visible')
cy.findByText('Gray').should('be.visible')

cy.findByRole('combobox').type('{backspace}')
cy.findAllByRole('option').should('have.length', 12)
})
})
})
21 changes: 21 additions & 0 deletions docusaurus/pages/shadow-dom/useCombobox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import * as React from 'react'

import DropdownCombobox from '../useCombobox'
import {ReactShadowRoot} from '../../../test/react-shadow'

const style = {
padding: '20px',
}

export default function MultipleComboboxShadow() {
return (
<div style={style}>
<h2>Shadow DOM</h2>
<div data-testid="shadow-root">
<ReactShadowRoot>
<DropdownCombobox />
</ReactShadowRoot>
</div>
</div>
)
}
27 changes: 27 additions & 0 deletions docusaurus/pages/shadow-dom/useMultipleCombobox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import * as React from 'react'

import DropdownMultipleCombobox from '../useMultipleCombobox'
import {ReactShadowRoot} from '../../../test/react-shadow'

const style = {
padding: '20px',
}

export default function MultipleComboboxShadow() {
return (
<div style={style}>
<div>
<button>Button before shadow root</button>
</div>
<h2>Shadow DOM</h2>
<div data-testid="shadow-root">
<ReactShadowRoot>
<DropdownMultipleCombobox />
</ReactShadowRoot>
</div>
<div>
<button>Button after shadow root</button>
</div>
</div>
)
}
12 changes: 12 additions & 0 deletions docusaurus/pages/shadow-dom/useSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as React from 'react'

import DropdownSelect from '../useSelect'
import {ReactShadowRoot} from '../../../test/react-shadow'

export default function DropdownSelectShadow() {
return (
<ReactShadowRoot>
<DropdownSelect />
</ReactShadowRoot>
)
}
5 changes: 3 additions & 2 deletions src/__tests__/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"react/prop-types": "off",
"react/display-name": "off",
"react/no-deprecated": "off",
"no-console": "off"
}
"no-console": "off",
"no-unused-vars": "off",
},
}
Loading