Skip to content

Added a new linear system example - #5

Open
adowling2 wants to merge 7 commits into
mainfrom
new-example
Open

adowling2 wants to merge 7 commits into
mainfrom
new-example

Conversation

@adowling2

Copy link
Copy Markdown
Contributor

No description provided.

@adowling2
adowling2 marked this pull request as draft March 20, 2025 21:59
Comment thread linear-system.ipynb Outdated
" # Update time discretization\n",
" time = self.data['t']\n",
" m.t.update((min(time), max(time)))\n",
" m.t.update(time)\n",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" m.t.update(time)\n",
" m.t.update(time)\n",
" m.t.set_changed(True)\n",

This should fix the issue you noted on Slack

@adowling2

Copy link
Copy Markdown
Contributor Author

Here are the results with Pyomo 6.8.2:

b9066ecb-c564-46a8-b173-1e4df5613d2c

@adowling2

Copy link
Copy Markdown
Contributor Author

Results with Pyomo 6.9.1:

400b3c00-5e47-467a-a146-bd5656976ac8

@adowling2 adowling2 self-assigned this Mar 21, 2025
@adowling2
adowling2 marked this pull request as ready for review March 21, 2025 22:50
@adowling2 adowling2 changed the title WIP: Added a new linear system example Added a new linear system example Mar 22, 2025
@adowling2

Copy link
Copy Markdown
Contributor Author

@djlaky We can merge this on Monday (or after you take a look)

@adowling2

Copy link
Copy Markdown
Contributor Author

@smondal13 May I get your help converting new notebook into a standalone example? I would like it to serve as an easy way to learning both parmest basics as well as Pyomo.DoE.

@smondal13

Copy link
Copy Markdown
Contributor

@adowling2 I will look into it.

@djlaky

djlaky commented Mar 24, 2025

Copy link
Copy Markdown
Contributor

@djlaky We can merge this on Monday (or after you take a look)

This looks good. Good to know for our examples.

@adowling2

Copy link
Copy Markdown
Contributor Author

@smondal13 Should we close this PR? Did we move the example to somewhere else? If yes, just post the other PR link here, and we will close.

@smondal13

Copy link
Copy Markdown
Contributor

@smondal13 Should we close this PR? Did we move the example to somewhere else? If yes, just post the other PR link here, and we will close.

No, we did not move the example anywhere. But I can close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants