Repository navigation
Allow large save writes and fix replacement verification - #16
Merged
Merged
Conversation
Compare the written target with the replacement payload and reserve backup comparisons for preserved files, including the displayed verification status. Add offline writer regression tests for changed and identical replacements, stale backups, corrupted read-backs, and missing or unreadable targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #12 adds bounded hashing for large save files, but its single-file writer reports failure after successfully replacing saveg.dat: postwrite verification checks the replacement against both the new payload and the original backup.
This PR carries forward the original contributor commit from #12 and adds a fix:
Validation:
The GitHub integration could not update the contributor's branch ("Resource not accessible by integration"), so the corrected changes are published here. The original contributor commit and authorship are preserved. This is the corrected replacement for #12.