Skip to content

Add missing include to fix compile error on some platforms - #145

Merged
dougbinks merged 1 commit into
dougbinks:devfrom
3434yz:fix-task-scheduler
Jun 3, 2026
Merged

dougbinks merged 1 commit into
dougbinks:devfrom
3434yz:fix-task-scheduler

Conversation

@3434yz

@3434yz 3434yz commented May 19, 2026 •

Copy link
Copy Markdown
Contributor

platform: MacOS

====================[ 构建 | archers | Release ]==================================
cmake --build /path/to/archers/cmake-build-release --target archers -j 16
[1/3] Building CXX object xx/enkiTS/CMakeFiles/enkiTS.dir/src/TaskScheduler.cpp.o
FAILED: [code=1] xx/enkiTS/CMakeFiles/enkiTS.dir/src/TaskScheduler.cpp.o
/usr/bin/c++ -DENKITS_TASK_PRIORITIES_NUM=3 -I/path/to/archers/src -I/path/to/archers/src/g -I/path/to/archers/src/t1 -I/path/to/archers/src/t2 -I/path/to/archers/src/t3 -I/path/to/archers/src/t4 -I/path/to/xx2/enkiTS/src -pthread -std=c++11 -stdlib=libc++ -O3 -DNDEBUG -std=c++2b -arch arm64 -fcolor-diagnostics -MD -MT xx/enkiTS/CMakeFiles/enkiTS.dir/src/TaskScheduler.cpp.o -MF xx/enkiTS/CMakeFiles/enkiTS.dir/src/TaskScheduler.cpp.o.d -o xx/enkiTS/CMakeFiles/enkiTS.dir/src/TaskScheduler.cpp.o -c /path/to/xx2/enkiTS/src/TaskScheduler.cpp
/path/to/xx2/enkiTS/src/TaskScheduler.cpp:1205:15: error: no member named 'is_trivial' in namespace 'std'
1205 | if( !std::is_trivial::value )
| ^~~~~~~~~~
/path/to/xx2/enkiTS/src/TaskScheduler.cpp:1205:26: error: 'T' does not refer to a value
1205 | if( !std::is_trivial::value )
| ^
/path/to/xx2/enkiTS/src/TaskScheduler.cpp:1201:19: note: declared here
1201 | template
| ^
/path/to/xx2/enkiTS/src/TaskScheduler.cpp:1205:30: error: no member named 'value' in the global namespace
1205 | if( !std::is_trivial::value )

@3434yz 3434yz closed this May 19, 2026
@3434yz 3434yz reopened this May 19, 2026
@3434yz 3434yz closed this May 19, 2026
@3434yz 3434yz reopened this May 19, 2026
@dougbinks
dougbinks self-requested a review May 19, 2026 16:47
@dougbinks dougbinks self-assigned this May 19, 2026
@dougbinks
dougbinks changed the base branch from master to dev June 3, 2026 13:03
@dougbinks dougbinks changed the title Update enkiTS submodule to include custom TaskScheduler changes Add missing include to fix compile error on some platforms Jun 3, 2026
@dougbinks
dougbinks merged commit 0289cf6 into dougbinks:dev Jun 3, 2026
6 checks passed
@dougbinks

Copy link
Copy Markdown
Owner

Merged into Dev, I will merge into Main soon.

Many thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants