-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix cursor editor icon width calculation for proper DPI scaling #14168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
…stency Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14168 +/- ##
===================================================
- Coverage 77.15877% 77.15187% -0.00691%
===================================================
Files 3279 3279
Lines 645333 645335 +2
Branches 47720 47720
===================================================
- Hits 497931 497888 -43
- Misses 143719 143749 +30
- Partials 3683 3698 +15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
src/System.Windows.Forms.Design/src/System/Drawing/Design/CursorEditor.CursorUI.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a DPI scaling issue in the cursor editor where certain cursors (HSplit, VSplit) appeared wider than others at specific DPI settings (125%, 175%, 225%, 250%), causing display alignment issues in the PropertyGrid. The fix standardizes icon width by calculating it once using the default cursor as a reference, rather than computing individual widths for each cursor during drawing.
Key changes:
- Introduces a
_cursorWidthfield calculated once in the constructor usingCursors.Default - Refactors
OnDrawItemto use the pre-calculated width instead of computing it per cursor - Improves performance by eliminating repeated DPI scaling calculations during drawing


Fixes #14167
Root Cause
Icons similar to HSplit.cur, VSplit.cur are wider than other icons at certain DPI settings (such as 125%, 175%, 225%, 250%), which is causing the webtable to display abnormally.
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
150DPI:
150DPI.mp4
175DPI:
175DPI.mp4
200DPI:
200DPI.mp4
225DPI:
225DPI.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow