You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I finally got fed up enough with builds failing due to race conditions on files shared between projects and decided to fix it. The arcade build system loads all solutions and builds them in parallel. A project in the dotnet-svcutil.sln would reference a System.ServiceModel.* project and attempt to build it as a dependency. Simultaneously, System.ServiceModel.sln was being build which would try to build the same project. Sometimes they would try to build the common project at the same time, and you would get a build error.
The fix is to have a single .sln file with everything in it, and use .slnf files to filter the set of projects loaded when working on code in Visual Studio.
I have validated that the new .slnf files work when being passed to build -vs solution.slnf. They don't work when being passed to build -build -project solution.slnf, but I don't think that will be a problem.
@imcarolwang, can you give this a try and see if it works well for you? If it does, we can merge this and improve the stability or PR builds.
I’ve tried the updated solution and confirmed that it works fine for me locally. However, I do have one concern: when performing individual product builds and tests for System.ServiceModel or dotnet-svcutil, I need to edit the AllProjects.slnx file. Are there any other ways or build command options available to achieve this without modifying the .slnx file directly?
I will hold off on this change until I have a good answer for that. I'll ask the arcade team if there's a solution to build -build -project not working with slnf files.
Azure Pipelines successfully started running 2 pipeline(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finally got fed up enough with builds failing due to race conditions on files shared between projects and decided to fix it. The arcade build system loads all solutions and builds them in parallel. A project in the dotnet-svcutil.sln would reference a System.ServiceModel.* project and attempt to build it as a dependency. Simultaneously, System.ServiceModel.sln was being build which would try to build the same project. Sometimes they would try to build the common project at the same time, and you would get a build error.
The fix is to have a single .sln file with everything in it, and use .slnf files to filter the set of projects loaded when working on code in Visual Studio.
I have validated that the new .slnf files work when being passed to
build -vs solution.slnf. They don't work when being passed tobuild -build -project solution.slnf, but I don't think that will be a problem.