Conversation
The .NET runtime now ships Microsoft.DiaSymReader.Native.*.dll in the shared framework, so the Microsoft.DiaSymReader.Native package reference is no longer needed. Load the native binaries from the runtime instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Load the native binaries from the .NET runtime instead of copying them into test output. .NET tests rely on the runtime load path. .NET Framework tests call AddDllDirectory with the installed .NET shared-framework directory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Wrap the test helper in a single NETFRAMEWORK block instead of scattering ifdefs through APIs that only run on .NET Framework. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
64-bit is the default; no need to set the architecture explicitly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Install the x86 shared framework from global.json tools.runtimes and run Framework tests on both x64 and x86. Core x86 is omitted until Microsoft.DiaSymReader passes Guid by pointer. Framework tests locate Native.x86.dll under .dotnet/x86. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .NET runtime now ships
Microsoft.DiaSymReader.Native.*.dllin the shared framework, so theMicrosoft.DiaSymReader.Nativepackage reference is no longer needed.