Fix GenerateAssemblyInfo timing to support XamlPreCompile targets #52223
+86
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinUI3 projects with
DisableRuntimeMarshalling=truewere getting SYSLIB1051 errors despite the property being set. The XamlPreCompile target runs before CoreCompile but wasn't seeing the SDK-generated DisableRuntimeMarshallingAttribute in the intermediate AssemblyInfo file.Changes
AfterTargets="PrepareForBuild"to ensure GenerateAssemblyInfo runs before XamlPreCompile while maintaining existing BeforeTargets orderingEnableSourceControlManagerQueries=false) in tests that expect no source revision ID, as the timing change now picks up Git repository informationReproduction
With this change, the DisableRuntimeMarshallingAttribute is generated early enough for XamlPreCompile to see it.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.