Fix -extra container variant check to support .NET 9+ #52161
+46
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-extrabase image variant was only applied for .NET 8 due to an equality check instead of a range check, breaking support for .NET 9 and later.Changes
Fixed version comparison in
ComputeDotnetBaseImageAndTag.cs:parsedVersion.Major == FirstVersionWithNewTaggingSchemetoparsedVersion.Major >= FirstVersionWithNewTaggingScheme-extravariant containing ICU and tzdataAdded test coverage for .NET 9 and .NET 10:
FDDConsoleAppWithCulturesAndOptingIntoChiseledGetsExtrasForNet9AndLaterFDDAspNetAppWithCulturesAndOptingIntoChiseledGetsExtrasForNet9AndLater-extratags for future SDK versionsContext
The
-extravariants became available starting with .NET 8's new tagging scheme. The original implementation incorrectly hard-coded the version check to exactly 8, preventing the logic from working with newer SDK versions.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.