Skip to content

Fix pipe2 detection for Apple deployment targets #134028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 4 commits into from
Sep 16, 2026
+12 −1
Merged

Fix pipe2 detection for Apple deployment targets #134028

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c8c8c8
Fix pipe2 detection for Apple deployment targets
lewing Sep 16, 2026
05c41fb
Keep PAL pipe2 probe out of shared cache
lewing Sep 16, 2026
f28bd4b
Propagate PAL pipe2 probe result
lewing Sep 16, 2026
82b4b11
Use standard CMake pipe2 symbol check
lewing Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/coreclr/pal/src/configure.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,18 @@ check_function_exists(vm_read HAVE_VM_READ)
check_function_exists(semget HAS_SYSV_SEMAPHORES)
check_function_exists(pthread_mutex_init HAS_PTHREAD_MUTEXES)
check_function_exists(ttrace HAVE_TTRACE)
check_function_exists(pipe2 HAVE_PIPE2)

set(PREVIOUS_CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS})
Comment thread
lewing marked this conversation as resolved.
if(CLR_CMAKE_HOST_APPLE)
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -Werror=unguarded-availability-new")

@akoeplinger akoeplinger Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do this more globally rather than just for this symbol, opened #134073

endif()
check_cxx_symbol_exists(pipe2 unistd.h PAL_HAVE_PIPE2)
Comment thread
lewing marked this conversation as resolved.
if(PAL_HAVE_PIPE2)
set(HAVE_PIPE2 1 CACHE INTERNAL "" FORCE)
else()
set(HAVE_PIPE2 0 CACHE INTERNAL "" FORCE)
Comment thread
lewing marked this conversation as resolved.
endif()
set(CMAKE_REQUIRED_FLAGS ${PREVIOUS_CMAKE_REQUIRED_FLAGS})

check_cxx_source_compiles("
#include <pthread_np.h>
Expand Down