Skip to content

JIT: Correct typeof(void).IsPrimitive constant folding #133967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 2 commits into from
Sep 16, 2026
+5 −3
Merged

JIT: Correct typeof(void).IsPrimitive constant folding #133967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
323627a
Initial plan
Copilot Sep 15, 2026
aea1f68
Fix Type.IsPrimitive constant folding for System.Void
Copilot Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/coreclr/jit/importercalls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4389,10 +4389,11 @@ GenTree* Compiler::impIntrinsic(CORINFO_CLASS_HANDLE clsHnd,
case NI_System_Type_get_IsPrimitive:
// getTypeForPrimitiveValueClass returns underlying type for enums, so we check it first
// because enums are not primitive types.
if ((info.compCompHnd->isEnum(hClass, nullptr) == TypeCompareState::MustNot) &&
info.compCompHnd->getTypeForPrimitiveValueClass(hClass) != CORINFO_TYPE_UNDEF)
if (info.compCompHnd->isEnum(hClass, nullptr) == TypeCompareState::MustNot)
{
retNode = gtNewTrue();
CorInfoType type = info.compCompHnd->getTypeForPrimitiveValueClass(hClass);
retNode =
gtNewIconNode((type != CORINFO_TYPE_UNDEF) && (type != CORINFO_TYPE_VOID) ? 1 : 0);
}
else
{
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Intrinsics/TypeIntrinsics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ private static void IsPrimitiveTests()
IsTrue(typeof(IntPtr).IsPrimitive);
IsTrue(typeof(UIntPtr).IsPrimitive);

IsFalse(typeof(void).IsPrimitive);
IsFalse(typeof(Enum).IsPrimitive);
IsFalse(typeof(ValueType).IsPrimitive);
IsFalse(typeof(SimpleEnum).IsPrimitive);
Expand Down
Loading