-
Notifications
You must be signed in to change notification settings - Fork 287
Add debug build configuration support for MAUI Android and iOS scenarios #5061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: LoopedBard3 <15679138+LoopedBard3@users.noreply.github.com>
Co-authored-by: LoopedBard3 <15679138+LoopedBard3@users.noreply.github.com>
Co-authored-by: LoopedBard3 <15679138+LoopedBard3@users.noreply.github.com>
…emove unnecessary str() conversions Co-authored-by: LoopedBard3 <15679138+LoopedBard3@users.noreply.github.com>
Capitalize Debug (debug -> Debug)
|
@copilot please update the two new lines like: to instead only add BuildConfig to the configurations when it is not the default value. This will ensure we don't break the current trends we have and instead make it so that these are just new configs when running as Debug. |
Co-authored-by: LoopedBard3 <15679138+LoopedBard3@users.noreply.github.com>
Add banner for non-release build config
Refactor non-release build banner logic for clarity and to fix args not being available.
|
There are a few issues being seen in the test run (https://dev.azure.com/dnceng/internal/_build/results?buildId=2884653&view=results):
I am working on the version extraction issue, the first two issues should be followed up in another PR, and I the cause of the last needs to be investigated. @matouskozak do we expect the CoreCLR runs to currently be compatible with building Debug or have you seen this error before? |
|
Latest PR test run fixed the Version Extraction: https://dev.azure.com/dnceng/internal/_build/results?buildId=2885485&view=logs&j=1d97bf9c-ba2d-53d3-bdd3-7b15b8044ae4&t=5d9c0cfc-3317-59fc-fd95-b8aec0e8a6bb. |
This reverts commit 7ef2af6.
|
I went ahead and disabled the R2R Debug jobs as they are failing so we can start getting some results for this. The issues that need to be tracked include:
I did also confirm that the BuildConfig=Debug RunConfiguration item is present. |
|
This partially completes: #5061 |
Adds support for debug configured runs (
-c Debug) for MAUI Android and iOS scenario benchmarks by passingbuildConfig: debugthrough the pipeline and into the pre.py publish command.Changes
scripts/run_performance_job.pyDEFAULT_BUILD_CONFIGconstant for the default "Release" configurationget_run_configurations()to includeBuildConfigin configurations formaui_scenarios_androidandmaui_scenarios_iosrun_kinds only when the build configuration is not the default (Release). This preserves existing trend data for Release builds while tracking Debug builds as new configurations.BuildConfigenvironment variable for MSBuild payload preparationeng/performance/maui_scenarios_android.proj-c $(BuildConfig)to pre.py publish commandeng/performance/maui_scenarios_ios.proj-c Releaseto-c $(BuildConfig)eng/pipelines/sdk-perf-jobs.ymlbuildConfig: debugfor all existing MAUI scenarios:Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.