-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix Wasm.Performance benchmark invalid Locale #64801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I have tested this locally and was able to successfully run the BlazorWasm test docker container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an invalid culture identifier error (en-us@posix) in the ASP.NET Performance lab by explicitly setting the browser locale to "en-US" when creating a new Playwright page in the Wasm.Performance benchmark driver.
- Updates the
NewPageAsynccall to include locale configuration
@ilonatommy any idea where the "posix" part is coming from ? Are there other customers suffering from that ?
I guess this is a timeout after Mono/Wasm runtime failed to start, right ? |
I don't know, this? microsoft/playwright#34046 |
Fix BlazorWasm test invalid Locale
Update Wasm.Performance benchmark to explicitly set Locale to en-US.
Description
Update Wasm.Performance benchmark to explicitly set Locale to en-US when browsing to the benchmark page to fix an invalid culture identifier (
en-us@posix) error being hit in the ASP.NET Performance lab.Fixes #64450
The local test still gives the following error but it seems to be after all of the testing, when the container shutsdown:
[Browser Log]: Failed to load resource: net::ERR_CONNECTION_RESETFull local test log: