Minimum required changes for working tests

[dgvives]

Minimum required changes for working tests.
Updated models and broken functionality

[jterry75]

Some questions

[jterry75]

I think just one question if we can improve the StreamUtil even better here otherwise this looks really good thanks for the contributions

[dgvives]

@jterry75 I tried your suggestion for StreamUtil and found that ReadAsync(token) wasn't getting any line when token was cancelled.
Approach from #343 fits nicely, is working and validated by running tests.

[The-TT-Hacker]

This pull request has my minimal changes to update the go code generation to the newer go modules.
Well I guess it's not 100% minimal because it has added the service logs endpoint which was the motivation for updating the code generation.
#472

[jterry75]

I'm ok with this at the moment. @galvesribeiro - A second look would be appreciated if you have the time

[galvesribeiro]

Sure! Will do it Today. Thanks! Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Justin <notifications@github.com> Sent: Tuesday, January 19, 2021 7:45:10 PM To: dotnet/Docker.DotNet <Docker.DotNet@noreply.github.com> Cc: Gutemberg Ribeiro <gutemberg@outlook.com>; Mention <mention@noreply.github.com> Subject: Re: [dotnet/Docker.DotNet] Minimum required changes for working tests (#481) I'm ok with this at the moment. @galvesribeiro<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgalvesribeiro&data=04%7C01%7C%7C2238e550b73444749c2108d8bccbe10f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637466931123141785%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lAf7GnKK%2FKTx0s%2Bch4wBQwmO%2FOF8Ptv%2BU2IF58ECN9s%3D&reserved=0> - A second look would be appreciated if you have the time — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FDocker.DotNet%2Fpull%2F481%23issuecomment-763191359&data=04%7C01%7C%7C2238e550b73444749c2108d8bccbe10f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637466931123141785%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gEPvwlro%2F5uzZZqQ16RcEVdv9B3%2Fx2wcCurr3TJnF2M%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABD64OHTQO7JDHW73KEA5CDS2YDPNANCNFSM4V6ES2ZA&data=04%7C01%7C%7C2238e550b73444749c2108d8bccbe10f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637466931123151775%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NYxR2sGbk5mvw666%2F7nPIMBJirG%2FDON%2FBlsy7snLhoE%3D&reserved=0>.

[galvesribeiro]

Just a few tiny changes and we are good.

Thanks for the contribution! I really appreciate that!

[dgvives]

@galvesribeiro would you have a look at the CI/CD pipeline and build operations? It might be slightly different to include Directory.Build.props, I can't build or test using 'dotnet build' or 'dotnet test' from command here

Looks like updating Nerbank.GitVersioning package did the trick to compile using 'dotnet build'

[galvesribeiro]

Just one last thing.

[galvesribeiro]

Looks like updating Nerbank.GitVersioning package did the trick to compile using 'dotnet build'

Yeah, was about to say that. Github Actions changed the way the variables are added so they had to update the action to support that. Thanks!

[galvesribeiro]

LGTM. Thank you very much for the contribution and your patience!

[galvesribeiro]

@jterry75 Its all good to me. Any final thoughts? Otherwise I'll squash and merge to start the release of a new package.

[dgvives]

Next step: I'd like to order and cleanup the code base, applying Roslyn suggestions and removing warnings, to have it tidy and clean before continuing adding pending contributions/functionality.
No modifications in classes, methods, names, namespaces, none of that whatsoever.

[jterry75]

Sorry been out. @galvesribeiro - I'm good. Lets merge thanks!