Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function populate refactored with the following changes:

• Simplify logical expression using De Morgan identities [×2] (de-morgan)
• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)
• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Function download_thread refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)
• Lift code into else after jump in control flow (reintroduce-else)
• Swap if/else branches (swap-if-else-branches)

[dotcomboom]

Walrus (:=) requires Python 3.8+

[sourcery-ai]

Function dlPopup refactored with the following changes:

• Replace call to format with f-string (use-fstring-for-formatting)

[sourcery-ai]

Function go refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)
• Simplify logical expression using De Morgan identities (de-morgan)
• Replace call to format with f-string (use-fstring-for-formatting)

[sourcery-ai]

Function plural refactored with the following changes:

• Lift code into else after jump in control flow (reintroduce-else)
• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Lines 21-84 refactored with the following changes:

• Simplify logical expression using De Morgan identities [×2] (de-morgan)
• Simplify conditional into switch-like form [×11] (switch)
• Remove redundant conditional (remove-redundant-if)
• Move setting of default value for variable into else branch (introduce-default-else)
• Merge nested if conditions (merge-nested-ifs)
• Merge else clause's nested if statement into elif [×2] (merge-else-if-into-elif)
• Move assignment closer to its usage within a block [×2] (move-assign-in-block)
• Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)
• Simplify boolean if expression (boolean-if-exp-identity)
• Replace if statement with if expression (assign-if-exp)
• Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

[sourcery-ai]

Function Request.url refactored with the following changes:

• Move setting of default value for variable into else branch (introduce-default-else)
• Use f-string instead of string concatenation (use-fstring-for-concatenation)
• Replace call to format with f-string [×2] (use-fstring-for-formatting)
• Simplify logical expression using De Morgan identities [×2] (de-morgan)
• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Function parse_menu refactored with the following changes:

• Use named expression to simplify assignment and conditional (use-named-expression)

[sourcery-ai]

Function parse_url refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)
• Replace call to format with f-string (use-fstring-for-formatting)

This removes the following comments ( why? ):

# NOT to be confused with actual gopher queries, which use %09

[sourcery-ai]

Function parse_gophermap refactored with the following changes:

• Use f-string instead of string concatenation [×5] (use-fstring-for-concatenation)
• Replace if statement with if expression [×2] (assign-if-exp)
• Merge nested if conditions (merge-nested-ifs)
• Replace a for append loop with list extend (for-append-to-extend)