Repository navigation
Fix Release sample and ABI validation CI - #3
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8ecac9d9-7be8-4ea3-a69c-5ae32e36fd23
Keep ReadyToRun enabled while disabling unsupported trimming for the framework-dependent sample. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8ecac9d9-7be8-4ea3-a69c-5ae32e36fd23
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8ecac9d9-7be8-4ea3-a69c-5ae32e36fd23
richiemsft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first clean Windows workflow exposed two CI-only issues. Restore now runs with
Configuration=Release, preserving ReadyToRun coverage and acquiring its runtime pack. The framework-dependent sample no longer enables unsupported trimming. ABI validation now passes the x64/ARM64 DLL paths through a valid PowerShell array.nnFixes the failures in runs 35280103862 and 35283358693.