Strange behaviour if tabView:shouldAllowTabViewItem:toLeaveTabBar: returns NO #27

Activity

1. crairdin commented on Aug 27, 2013

   

   crairdin

   on Aug 27, 2013

   More actions

   I also saw this erroneous behavior. If you look at the comments in performDragOperation you'll see why it doesn't work: When you try to put the dragged cell back into the original tab bar at the same index you took it from, you will fail to account for the placeholders that are inserted when dragging begins. Rather than duplicating the code that removes the placeholders, I fixed it by modifying draggedImageEndedAt:operation: so that instead of simply putting the dragged cell back at the index from which it was taken, it calls performDragOperation. Here's the modified code:

           // put cell back
           // 8/27/13 - You can't just put this back at the same location because there are 
           // placeholders inserted during dragging. See comments in performDragOperation.
           // AVOID:
           // [[self sourceTabBar] insertCell:[self draggedCell] atIndex:[self draggedCellIndex]];
           [self performDragOperation];
   

   It's possible I'm not accounting for all conditions, but this seems to be working.