Choosing mesh compression type per primitive#929
Open
marwie wants to merge 2 commits intodonmccurdy:mainfrom
Open
Choosing mesh compression type per primitive#929marwie wants to merge 2 commits intodonmccurdy:mainfrom
marwie wants to merge 2 commits intodonmccurdy:mainfrom
Conversation
marwie
commented
Apr 30, 2023
Contributor
Author
marwie
left a comment
marwie
left a comment
There was a problem hiding this comment.
The model I've been testing with: CarbonFrameBike.zip
Falsely skipped meshopt results in:
Owner
|
Hi @marwie, sorry for the slow followup on this – are you still interested in supporting per-primitive compression? And, am I correct in understanding that the PR currently is expected to work trivially for Draco, but will need more investigation for Meshopt? |
Contributor
Author
|
Hey no problem. For draco it seemed to work easily yes but I didnt get it to work with meshopt and didnt have time to look into it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
as suggested in the discussion here I've started adding the skips in draco
and tried to add it to meshopt too but this is not yet working. I'm still including the commit here for talking about the approach (I tried skipping meshopt for every second primitive (or rather all accessors that are used by every second primitive))