Skip to content

perf(functions): Refactor dedup() using Property#toHash()#1761

Draft
donmccurdy wants to merge 7 commits intoperf/bench-dedupfrom
perf/dedup-hashed
Draft

perf(functions): Refactor dedup() using Property#toHash()#1761
donmccurdy wants to merge 7 commits intoperf/bench-dedupfrom
perf/dedup-hashed

Conversation

@donmccurdy
Copy link
Copy Markdown
Owner

@donmccurdy donmccurdy commented Nov 11, 2025

Refactor of the dedup function, using hashProperty function (from #1757) to avoid O(n2) iteration over properties.

Related:

PR Dependency Tree

This tree was auto-generated by Charcoal

@donmccurdy
Copy link
Copy Markdown
Owner Author

donmccurdy commented Nov 12, 2025

UPDATE: Resolved.

The dedup+hash approach is currently failing for one case with skins, see:

Need a unit test on this "recursive skinning" setup if possible - it would have been easy to miss!

@donmccurdy donmccurdy modified the milestones: v4.2, v4.3 Dec 5, 2025
@donmccurdy donmccurdy modified the milestones: v4.3, v4.4 Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant