Open
Conversation
marwie
force-pushed
the
feature/simplifyWithAttributes
branch
from
9b0df20 to
d7274e5
Compare
marwie
force-pushed
the
feature/simplifyWithAttributes
branch
from
6f0e19b to
ca074ab
Compare
packages/functions/src/simplify.ts
Outdated
| let attributes = 8; // 3 color, 3 normal, 2 uv | ||
| const attributesArray = new Float32Array(positionArray.length / 3 * attributes); | ||
|
|
||
| const attrib_weights = [ |
There was a problem hiding this comment.
Why isn't this variable in camelCase? Shouldn't this be detected by the linter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1706
Hello Don,
Been a bit slow in regards to testing the new simplifyWithAttributes feature.
I've went ahead and replaced the original
simplifymethod with the newsimplifyWithAttributesoption by default here since it seems like there's no good reason to keep both options if I'm not mistaken.There are still some comments included that would need to be removed. For now I've published a pre-release version as a separate package with these changes below and will start testing and using this in our tools the coming weeks.
Let me know if you have any concerns or things you'd like to change. Otherwise I'm also happy to report back any findings (if any) after this has been rolled-out to more of our users (as of now it's only in internal pre-release versions)