Improve and complete German translations - #239
Conversation
Complete and improve German localization across all namespaces.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Username Password | 35b9d86 | public/locales/de/auth.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
I've double checked my pull request and all included JSON files contributing to the German translation. This GitGuardian finding is a false positive. public/locales/de/auth.json is a UI translation file — the flagged lines are German labels for form fields ("yourUsername": "Dein Benutzername", "newPassword": "Neues Passwort"), mirroring the same keys in en/auth.json. No credential is present anywhere in this PR; the generic username/password detector is matching on the key names. |
| "useDifferentAccount": "Anderes Konto verwenden", | ||
| "yourUsername": "Dein Benutzername", | ||
| "backToSignIn": "Zurück zur Anmeldung", | ||
| "confirmNewPassword": "Neues Passwort bestätigen", |
There was a problem hiding this comment.
This GitGuardian finding is a false positive. public/locales/de/auth.json is a UI translation file — the flagged lines are German labels for form fields ("yourUsername": "Dein Benutzername", "newPassword": "Neues Passwort"), mirroring the same keys in en/auth.json. No credential is present anywhere in this PR; the generic username/password detector is matching on the key names.
| "subAccountNameLabel": "Name des Unterkontos", | ||
| "serverSettings": "Servereinstellungen", | ||
| "useDifferentAccount": "Anderes Konto verwenden", | ||
| "yourUsername": "Dein Benutzername", |
There was a problem hiding this comment.
This GitGuardian finding is a false positive. public/locales/de/auth.json is a UI translation file — the flagged lines are German labels for form fields ("yourUsername": "Dein Benutzername", "newPassword": "Neues Passwort"), mirroring the same keys in en/auth.json. No credential is present anywhere in this PR; the generic username/password detector is matching on the key names.
|
sorry seems it conflicts with the Crowdin translation that i just merged. If you can resolve the conflict would be great; otherwise, I will try to pull your branch this weekend and do it |
|
got sometime fix the conflict #242 |
This PR significantly improves the German localization.
Changes:
The German locale now has full key coverage compared to the current English locale.
Related to #145