feat(i18n): add Russian (ru) localization - #238
Merged
Conversation
Adds `public/locales/ru/*` for all eleven namespaces — auth, chores, common, filters, history, labels, points, projects, settings, things, timer — covering every key currently in `public/locales/en` on develop. Two one-line source changes are needed for it to work: - `LocalizationContext.jsx` — registers `ru` in AVAILABLE_LANGUAGES, so the language shows up in the picker. - `i18n/config.js` — `import 'moment/locale/ru'`. Without it the UI translates but every date stays English, which reads worse than no translation at all. This is the same one-line-per-language change as donetick#147; only the `ru` line is here so this PR stands alone. Notes for review: - Plural forms use the full Russian set (`_one/_few/_many/_other`). Russian has four plural categories, not two — with only `_one/_other` a count of 5 falls through to `_other` and renders ungrammatically. - Terminology is held consistent across all namespaces. Donetick uses "chore" and "task" for the same object; Russian picks one word and keeps it everywhere. - No English strings were changed, and no keys were added or removed. - `eslint`, `prettier -c`, `npm run lint:i18n` and `npm run build` are all green on this branch. Supersedes donetick#143, which I closed in August because it covered three namespaces when there were already eleven. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
public/locales/ru/*for all eleven namespaces — auth, chores, common, filters, history, labels, points, projects, settings, things, timer — covering every key currently inpublic/locales/enondevelop.Two one-line source changes are needed for it to work:
LocalizationContext.jsx— registersruinAVAILABLE_LANGUAGES, so the language appears in the picker.i18n/config.js—import 'moment/locale/ru'. Without it the UI translates but every date stays English, which reads worse than no translation at all. This is the same one-line-per-language change as fix: localize dates for all shipped languages (import moment locales) #147; only theruline is here so this PR stands on its own.Notes for review
_one/_few/_many/_other). Russian has four plural categories, not two — with only_one/_other, a count of 5 falls through to_otherand renders ungrammatically.eslint,prettier -c,npm run lint:i18nandnpm run buildare all green on this branch.On routing
If you'd rather Russian came through Crowdin like the other languages, that works for me too —
rujust isn't a target language in the project yet, so nothing can flow through it today (#230 brings ar, de, es, fr, ja, nl, pt, zh but not ru). Enable it and I'll upload this set there instead; close this PR in that case.Supersedes #143, which I closed in August because it covered three namespaces when there were already eleven.
Related: #145, #213.