fix: apply impersonation filter to View Tasks As feature - #193
Open
waterWang wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for the contribution! Do you mind rebasing please? sorry I push somethng might conflicted with your changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: View Tasks As impersonation filter not applied
Bug
When selecting "View Tasks As" from the UserSwitcher, the chores list was not filtering to only show tasks assigned to the selected user. The
getFilteredChoresuseMemo inMyChores.jsxwas usingprojectFilteredChoresdirectly without applying the impersonation filter, causing all chores to remain visible regardless of the impersonated user selection.Root Cause
The
getFilteredChoresfunction usedprojectFilteredChores(which only filters by project) as its base, missing the impersonation filter that was only applied insearchFilteredChores(from theuseChoreFiltershook). SincegetFilteredChoresis the primary data source used for rendering the chores list, the impersonation filter was effectively bypassed.Fix
Added impersonation filtering to
getFilteredChores: whenimpersonatedUseris set, the chore list is filtered to only include chores wherechore.assignedTo === impersonatedUser.userId. This mirrors the same logic already present inuseChoreFilters.Related issue
Closes donetick/donetick#501