i18n: extract the task-form picker fields (Part of #145) - #155
i18n: extract the task-form picker fields (Part of #145)#155everysingletear wants to merge 1 commit into
Conversation
|
Apologies for leaving this sitting red — I've now audited it properly rather than just rebasing and hoping. Six of the twelve files here were rewritten on The other six files are untouched, and they happen to be a coherent set on their own: the task-form field components. So rather than leave this conflicting indefinitely, I'd like to force-push it down to just those and retitle it "i18n: extract task form field strings" — That turns this into a small, conflict-free, reviewable PR. The rewritten half goes back into the queue behind the modal work, and I'll send it once that's settled. Full audit of the whole fork — what's ready and what's blocked on which refactor — is in #145. Shout if you'd rather I just close this one instead. |
0466477 to
fb8cac6
Compare
fb8cac6 to
90f4629
Compare
|
Rebased on current One thing worth flagging since it changed a file rather than just the dictionary: |
90f4629 to
b031cf7
Compare
|
@everysingletear this need a rebase also |
Part of donetick#145. Narrowed version of this PR, as announced in donetick#145 and donetick#168. The original diff covered twelve files; six were rewritten under me since — the modal unification, donetick#186, and the AddTaskModal autocomplete work. This reduces the PR to the seven files still untouched on `develop`: AssigneePickerField, AttachmentPickerField, DueDatePickerField, LabelsPickerField, ProjectPickerField, SmartTaskTitleInput, SubTask The rewritten half goes back in the queue behind your work, to be re-extracted against the current shape rather than replayed. Rebased on current `develop` after donetick#210 landed — the conflict was in the dictionaries only, and it shrank as a result: 20 keys to `en/chores.json` and 1 to `en/common.json`, since donetick#210 already carried the rest. AttachmentPickerField is re-extracted on top of your z-index refactor (462af85) rather than carried over; my branch predates it and still imported the removed `constants/zIndex`. English only — no translations, no behaviour change; every t() value is checked to appear character-for-character in the code it replaces (23 call sites). Also run through `eslint --rule no-undef`, which is what I should have been doing before donetick#216 and donetick#210 — see donetick#231.
b031cf7 to
ec66508
Compare
i18n: extract the task-form picker fields (
choresnamespace)Part of #145. This is the narrowed version of this PR, as announced in
#145 and #168.
The original diff covered twelve files; six of them were rewritten under
me since — the modal unification, #186, and the AddTaskModal autocomplete
work. Those hunks no longer applied, which is why GitHub kept showing
this as conflicting. Rather than resolve conflicts that aren't really
conflicts, this force-push reduces the PR to the seven files that are
still untouched on
develop:AssigneePickerField, AttachmentPickerField, DueDatePickerField,
LabelsPickerField, ProjectPickerField, SmartTaskTitleInput, SubTask
The rewritten half goes back in the queue behind your work, and I'll
re-extract it against the current shape rather than replaying the old
diff.
Rebased on current
develop. 16 keys added toen/chores.json, 1 toen/common.json. English only — no translations, no behaviour change;every t() value is verified to appear character-for-character in the code
it replaces.