fix(ui): restore inset Help scrollbar and scroll-hint title#460
Merged
Conversation
The gradient-graphs rebase (#459) adopted the pane-scrolling Help tab from #452 wholesale, losing the original presentation: - panel title reads 'Help · ↑/↓ scroll' while the text overflows - scrollbar sits one column inside the border (border stays intact), inset a row top and bottom to clear the title and rounded corners - right padding keeps the text clear of the gap + scrollbar columns - wheel scrolls three lines per tick instead of one Key handling stays on the shared try_handle_pane_scroll helper and the PaneScroll state introduced by #452.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #459 rebase resolved the Help tab conflict by adopting the #452 pane-scrolling implementation wholesale, which changed the tab's presentation. This restores the original look and feel on top of the shared scrolling infrastructure:
Help · ↑/↓ scrollwhile the text overflows, plainHelpwhen it fits.Key handling is unchanged: it stays on the shared
try_handle_pane_scrollhelper andPaneScrollstate from #452. The help_tab snapshot is regenerated accordingly.