Bump mailsuite to >=2.2.1 (release 10.0.2)#783
Merged
Conversation
mailsuite 2.2.1 raises the transitive mail-parser floor to >=4.2.1, which
stops mail-parser from returning a phantom ('', '') entry for absent address
headers (verified against samples/failure/* with mail-parser 4.2.1: cc/bcc
now parse to [] instead of [{address: ""}]). parsedmarc reads the mail-parser
object directly via its own parse_email(), so this previously caused an empty
{address: ""} Cc/Bcc entry to be indexed for every failure-report sample in
Elasticsearch/OpenSearch and emitted in JSON/S3/Kafka output.
The Reply-To-always-empty behavior in parsedmarc's own parse_email() (a
hyphen-vs-underscore key mismatch, not an upstream issue) and the failure
dashboards are out of scope here and tracked separately.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
=======================================
Coverage 85.58% 85.58%
=======================================
Files 17 17
Lines 4633 4633
=======================================
Hits 3965 3965
Misses 668 668 ☔ View full report in Codecov by Sentry. |
This was referenced May 24, 2026
seanthegeek
added a commit
that referenced
this pull request
May 24, 2026
PR #784 was stacked on the #783 branch and its base was never retargeted to master, so it merged into fix/mailsuite-2.2.1-empty-address instead of master. master therefore has 10.0.2 (#783's squash) but is missing the 10.0.3 changes. This re-lands exactly that delta — the Reply-To/Delivered-To parser fix, the ES/OS Reply-To header flattening, and the Splunk/OpenSearch/Grafana failure dashboard fixes, with the version bumped to 10.0.3. No mailsuite re-bump (the >=2.2.1 floor is already on master from 10.0.2). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch release
10.0.2bumping themailsuiterequirement from>=2.2.0to>=2.2.1.mailsuite 2.2.1 raises the transitive
mail-parserfloor to>=4.2.1, which pulls in two upstream fixes:('', '')entry for absent address headers (Cc,Bcc,Reply-To, etc.) instead of an empty list. parsedmarc reads themail-parserobject directly through its ownparse_email(), so this phantom flowed straight into output: an empty{address: ""}Cc/Bccentry was indexed for every DMARC failure-report sample in Elasticsearch/OpenSearch, and emitted in JSON/S3/Kafka output.email-module flaw where an RFC 2822 header containing a special character has the wrong portion identified as the addr-spec, which can let a crafted address bypass email-domain verification.Verification
Upgraded the venv to
mailsuite 2.2.1/mail-parser 4.2.1and re-parsed every sample insamples/failure/:cc[{"address": "", ...}][]bcc[{"address": "", ...}][]Full test suite passes against the upgraded dependency (
313 passed).Out of scope (tracked separately)
Reply-Toalways empty for failure samples — a hyphen-vs-underscore key mismatch in parsedmarc's ownparse_email()(reply_tovs mail-parser'sreply-to), not an upstream issue. The mail-parser bump does not address it.In-Reply-Tothreading header instead of the Reply-To address.🤖 Generated with Claude Code