5.16.1: simplify the removed-tag warning message#253
Merged
Conversation
The "the value is preserved for older DMARC readers but is not validated" clause was awkwardly worded and not actionable for the user. Drop it; the "removed in RFC 9989" message is enough. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 24 24
Lines 5715 5715
=======================================
Hits 5509 5509
Misses 206 206 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pct/rf/riwarning to just "Support for the {tag} tag was removed in RFC 9989" — the previous wording had an awkward clause about preserving the value for older readers.Test plan
pytest tests/test_dmarc.py— 86/86 pass (the existingtestRFC9989PctRemovedWarning/RfRemovedWarning/RiRemovedWarningsubstring assertions still match the shorter message).🤖 Generated with Claude Code