Skip to content

Match on PollutionEvent#95

Open
nstearns96 wants to merge 2 commits intodoldecomp:mainfrom
nstearns96:PollutionEvent
Open

Match on PollutionEvent#95
nstearns96 wants to merge 2 commits intodoldecomp:mainfrom
nstearns96:PollutionEvent

Conversation

@nstearns96
Copy link
Contributor

Just a small TU as I'm trying to learn everything to do with matching.

@decomp-dev
Copy link

decomp-dev bot commented Mar 25, 2026

Report for GMSJ01 (31af987 - 0fe07fe)

📈 Matched code: 28.39% (+0.01%, +388 bytes)
📈 Linked code: 13.56% (+0.01%, +388 bytes)
📈 Matched data: 31.24% (+0.03%, +180 bytes)
📈 Linked data: 13.34% (+0.03%, +180 bytes)

✅ 7 new matches
Unit Item Bytes Before After
mario/Map/PollutionEvent __sinit_PollutionEvent_cpp +764 0.00% 100.00%
mario/Map/PollutionEvent .bss +184 0.00% 100.00%
mario/Map/PollutionEvent TPollutionTest::~TPollutionTest() +116 0.00% 100.00%
mario/Map/PollutionEvent .data +40 0.00% 100.00%
mario/Map/PollutionEvent TPollutionTest::loadAfter() +32 0.00% 100.00%
mario/Map/PollutionEvent .ctors +4 0.00% 100.00%
mario/Map/PollutionEvent TPollutionTest::perform(unsigned long, JDrama::TGraphics*) +4 0.00% 100.00%
🥀 6 broken matches
Unit Item Bytes Before After
mario/GC2D/ShineFader TShineFader::update() -156 100.00% 0.00%
mario/GC2D/ShineFader TShineFader::~TShineFader() -148 100.00% 0.00%
mario/GC2D/ShineFader TShineFader::perform(unsigned long, JDrama::TGraphics*) -124 100.00% 0.00%
mario/GC2D/ShineFader TShineFader::registFadeout(unsigned short, unsigned short) -68 100.00% 0.00%
mario/GC2D/ShineFader .data -48 100.00% 0.00%
mario/GC2D/ShineFader TShineFader::load(JSUMemoryInputStream&) -32 100.00% 0.00%
📉 1 regression in an unmatched item
Unit Item Bytes Before After
mario/System/MarNameRefGen TMarNameRefGen::getNameRef(const char*) const 0 90.23% 90.23%

@@ -0,0 +1,13 @@
#ifndef MAP_TPOLLUTIONTEST_HPP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets name this file same as the cpp is called -- PollutionEvent.hpp


TPollutionTest::~TPollutionTest() { }

void TPollutionTest::loadAfter() { TNameRef::loadAfter(); }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of "UNUSED" stripped symbols in the symbol map for this file -- as a rule, we always add those to the decompiled files so as not to lose out on any additional information available to us. Please do this here too: TPollutionEventAreaObj, TPollutionEventMaze, TPollutionEventModelStamp and TPollutionEventModelStampMario seem to be thte 4 classes that should also be in this hpp/cpp pair!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants