feat: mount graphite config directory from host#80
Open
nemtsov wants to merge 1 commit into
Open
Conversation
The plugin creates a config directory and reports it via graphite:info --config-dir, but never mounts it into the container. Custom config files placed there (e.g. storage-schemas.conf) have no effect. Bind-mount the config directory into /opt/graphite/conf. On first container creation, seed the host config directory with the image defaults so the bind mount doesn't overlay with an empty directory. Fixes dokku#50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/) into/opt/graphite/confso custom config files (e.g.storage-schemas.conf) placed there take effectProblem
The plugin creates a config directory on service create and reports it via
graphite:info --config-dir, but never mounts it into the container. Custom config files placed there have no effect (#50).This was originally noted in commit
b0d8f38("prepare ground for config directory changes") from 2017, but it looks like the mount was never added.