Add ARM64 (aarch64) target support#23
Open
khamutov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off — thank you for maintaining these Rust bindings to Dokany. We've been running
dokan-rustin production on Windows ARM64 machines for about six months, carrying a small local patch to make it build there, and we'd like to upstream that change so it's maintained here rather than living in our fork.dokan-syspanics at build time on any target architecture other thanx86/x86_64. So cargo build --target aarch64-pc-windows-msvc fails today, even though Dokany ships ARM64 binaries and the v2.3.0 installer provides an ARM64 import library. This PR adds the aarch64 → ARM64 mapping in check_dokan_env, so dokan-sys/dokan build for Windows on ARM64.Validated on a native Windows-on-ARM64 machine with Dokany v2.3.0 installed: