Migrated to Fumadocs - #1
Conversation
Migrated RadioDoge docs website to Fumadocs framework maintaining similar feel of the recent website changes
DivineGod
left a comment
DivineGod
left a comment
There was a problem hiding this comment.
I think the main thing would be to trim down the PR to focus on pure refactor of website into fumadocs without any added features.
There are also some value in not moving and duplicating assets. Git tracking renames better if there aren't duplications.
Extract SVG files created inline in files into standalone assets. This allows easier modification and change tracking as well as keeping the source files they're in a bit easier to look through.
Co-authored-by: Ando “Thor” Nando <divinegod@gmail.com>
Co-authored-by: Ando “Thor” Nando <divinegod@gmail.com>
Co-authored-by: Ando “Thor” Nando <divinegod@gmail.com>
Co-authored-by: Ando “Thor” Nando <divinegod@gmail.com>
Co-authored-by: Ando “Thor” Nando <divinegod@gmail.com>
Deled the LLM route files that cause the build to fail.
DivineGod
left a comment
DivineGod
left a comment
There was a problem hiding this comment.
Looks better. Still a few things that would be nice to address.
And I’m not sure why there are extra content and cas changes that aren’t explained by a commit message.
Added improvements on top and side navbars, fixed animation on interactive map Addressed issues: #1 (review)
|
@DivineGod see if we can merge it now :) |
There was a problem hiding this comment.
Doing that I have to remove completely the Interactive Map do to erros on using it on this PR and that existed and exists already: https://radio.dogecoin.org/#interactive-map
What should be the best approach or what is your concern regarding this?
There was a problem hiding this comment.
Maybe pull into a separate PR or remove completely?
gigawallet docs doesn't have this one. And I really like how small that PR was. Much easier to review. Like how I missed this the first time around
There was a problem hiding this comment.
Sorry didn't understand what you suggest about the app/og/docs/[...slug]/route.tsx file :)
There was a problem hiding this comment.
Do you know what this file does, why it's included in this PR?
I don't and since it's extra code that's not in any of our other accepted fumadocs-based sites yet, it should be taken out and if needed in the future added as an improvement PR with proper rationalisation behind.
There was a problem hiding this comment.
yes, for each docs page it generates a image for when a URL is shared (Twitter/X, Discord, etc.), that image is used as the preview card
GET handles /og/docs/[...slug] , It loads the page from source, then uses Fumadocs with that page’s title and description
Was a way I found using the Fumadocs documentation with LLM :)
|
@DivineGod can you also check this to see if I can already merge to reflect the mew website structure? Much thanks :) |
2 participants
Migrated RadioDoge docs website to Fumadocs framework maintaining similar feel of the recent website changes