fix: missing tax table fatals listings/product pages (#2) - #4
Open
xre217 wants to merge 1 commit into
Open
Conversation
Fresh installs from shibeship.sql had no `tax` table, but listings and product pages still queried `SELECT … FROM tax` (HTML comments do not disable PHP). That caused PDO 1054/missing-table fatals on manage listings. - Create `tax` table + default zero-rate rows in shibeship.sql - Add DogeBridge::GetTaxRow() safe lookup - Use it on product listing paths - Re-enable tax category select with try/catch (no more landmine comment) Tips DOGE: DTRJECKXfxgnSzGbt7TYRikLPDocqvdmo5
Collaborator
|
It doesn't have the latest code that is active today on ShibeShip com will try to push it in the week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (#2)
shibeship.sqlnever created ataxtable, but product/listings code queriesSELECT … FROM tax WHERE category = …. HTML-commenting the tax UI inlistings.phpdid not stop PHP from running the query → PDO fatal on manage listings.Fix
taxtable + default zero-rate seed rows toshibeship.sqlDogeBridge::GetTaxRow()— safe lookup, zero rate if table/row missingDOGE
Happy to keep fixing ShibeShip/GigaWallet merchant rails. Tips/contract:
DTRJECKXfxgnSzGbt7TYRikLPDocqvdmo5· trefongwork@gmail.comAlso filed GigaWallet payment/event fixes if useful for ShibeShip checkout.